Skip to content

Experiments implementation#59

Merged
l-golofastov merged 26 commits intomainfrom
feature/experiments-implementation
Jun 11, 2025
Merged

Experiments implementation#59
l-golofastov merged 26 commits intomainfrom
feature/experiments-implementation

Conversation

@l-golofastov
Copy link
Contributor

Summary

Add critical value, power and time complexity experiments implementation with CLI configuration support.

Solve the issue: #58

Quick changelog

  • Experiments implementation (critical values, power, time complexity)
  • CLI for experiment configuration
  • Validation of CLI commands

What's new?

  • Critical values experiment
  • Power experiment
  • Time complexity experiment
  • CLI for configuration

@l-golofastov l-golofastov self-assigned this Jun 5, 2025
Copy link
Contributor

@f1i3g3 f1i3g3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо будет добавить пример использования через CLI.
Ну и сделать так, чтобы CI не ругался.

pyproject.toml Outdated

[tool.ruff]
line-length = 100
line-length = 120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Целиком поддерживаю)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я вернул как было, чтобы файлов в диффе поменьше было, но потом увеличим, если что)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мое мнение, что лучше все-таки 120

@l-golofastov
Copy link
Contributor Author

Надо будет добавить пример использования через CLI. Ну и сделать так, чтобы CI не ругался.

Обязательно, да

@l-golofastov l-golofastov requested a review from f1i3g3 June 8, 2025 16:37
Copy link
Contributor

@f1i3g3 f1i3g3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Блин, в CI дохрена чего исправлять.

@l-golofastov
Copy link
Contributor Author

Блин, в CI дохрена чего исправлять.

Я сделаю

Copy link
Contributor

@f1i3g3 f1i3g3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l-golofastov l-golofastov requested a review from f1i3g3 June 10, 2025 17:18
Copy link
Contributor

@f1i3g3 f1i3g3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вроде ок
Про пример конфига оставляю напоминалку

@l-golofastov l-golofastov merged commit 01446b6 into main Jun 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants