Change CLI experiment configure command. #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to configure experiment.
f1i3g3
requested changes
Dec 12, 2025
Contributor
f1i3g3
left a comment
f1i3g3
left a comment
There was a problem hiding this comment.
Ещё бы документацию потом обновить.
Ну и покрытие немного упало.
f1i3g3
changed the title
# Conflicts: # pysatl_criterion # pysatl_experiment/cli/commands/configure/storage_connection/storage_connection.py
# Conflicts: # pysatl_experiment/cli/cli/cli.py # pysatl_experiment/cli/commands/configure/storage_connection/storage_connection.py
f1i3g3
approved these changes
Jan 5, 2026
Contributor
f1i3g3
left a comment
f1i3g3
left a comment
There was a problem hiding this comment.
Есть парочка вопросов, особенно насчёт учёта параллелизации (я не очень понял).
А так вроде ок.
Contributor
There was a problem hiding this comment.
Оставлю здесь пометку на всякий случай.
Contributor
There was a problem hiding this comment.
Надо ли удалять параллелизацию?
Contributor
There was a problem hiding this comment.
Увидел в обновлённом, но всё равно не до конца понял.
Contributor
There was a problem hiding this comment.
Здесь же учитывается параллелизация?
Contributor
There was a problem hiding this comment.
Почему всё-таки не SQLAlchemy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now command configure has options to configure experiment.
Summary
Remove configure subcommands
Solve the issue: #96
Quick changelog
What's new?
Now experiment can be configure via configure command with options.