Skip to content

Fix small memory leak, update valgrind suppression file and prevent valgrind context errors. #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Fix small memory leak, update valgrind suppression file and prevent valgrind context errors. #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b96721
pyslurm.JobStep: fix small memory leak
tazend Jan 1, 2025
a331398
Update valgrind suppression file
tazend Jan 1, 2025
6923229
job live stats: fix uninitialized value errors in valgrind
tazend Jan 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyslurm/core/job/stats.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ cdef load_single(JobStep step):
else:
verify_rpc(rc)

memset(&locks, 0, sizeof(assoc_mgr_lock_t))
memset(&db_step, 0, sizeof(slurmdb_step_rec_t))
memset(&db_step.stats, 0, sizeof(slurmdb_stats_t))

Expand Down
3 changes: 3 additions & 0 deletions pyslurm/core/job/step.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ cdef class JobStep:

def _dealloc_impl(self):
slurm_free_job_step_info_members(self.ptr)
# Bug in slurm_free_job_step_info_members - submit_line is not freed
# there.
xfree(self.ptr.submit_line)
xfree(self.ptr)
slurm_free_update_step_msg(self.umsg)
self.umsg = NULL
Expand Down
19 changes: 18 additions & 1 deletion valgrind-pyslurm.supp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,15 @@
...
}

{
Slurm topology_g_init
Memcheck:Leak
match-leak-kinds: possible
...
fun:topology_g_init
...
}

{
Slurm slurm_auth_init
Memcheck:Leak
Expand All @@ -43,11 +52,19 @@
}

{
Slurm slurm_conf_init/slurm_init
Slurm slurm_conf_init
Memcheck:Leak
match-leak-kinds: possible
...
fun:slurm_conf_init
...
}

{
Slurm slurm_init
Memcheck:Leak
match-leak-kinds: possible
...
fun:slurm_init
...
}
Expand Down
Loading