Fix newmm tokenizer: Thai Character Cluster boundaries and maximal matching #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement comprehensive PyThaiNLP-compatible test suite for newmm tokenizer. Tests were failing due to incorrect Thai Character Cluster (TCC) boundary detection and suboptimal tokenization algorithm.
Changes
Thai Character Cluster boundary detection (
ThaiCharacterCluster.java)Newmm tokenization algorithm (
NewmmTokenizer.java)Test coverage (
NewmmTokenizerTest.java)testNewmmComprehensive()covering all PyThaiNLP test casesExample
All 17 tests pass (9 newmm + 8 trie tests).
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.