Remove star imports and enable F403/F405 Ruff checks#1207
Merged
Conversation
Co-authored-by: bact <128572+bact@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Revise code to remove star imports
Remove star imports and enable F403/F405 Ruff checks
Jan 15, 2026
bact
approved these changes
Jan 16, 2026
wannaphong
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What does this changes
Removes all star imports (
from module import *) from the codebase and enables Ruff checks F403/F405 to prevent their reintroduction.What was wrong
Star imports obscure the origin of imported names, making static analysis, type inference, and IDE autocomplete less effective. They were present in:
pythainlp/generate/thai2fit.py:from fastai.text import *tests/extra/testx_ulmfit.py:from fastai.text import *pythainlp/ulmfit/core.py: Docstring examples showing star importsHow this fixes it
Code changes:
AWD_LSTM,NumericalizeProcessor,TextList,TokenizeProcessor,Tokenizer,URLs,language_model_learner,untar_datadocument_vectorr→document_vectorConfiguration:
pyproject.tomlignored rulesBefore:
After:
Your checklist for this pull request
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.