Skip to content

Migrate Braille dot numbering to ISO/Unicode international standard#6

Merged
wannaphong merged 4 commits intomainfrom
copilot/update-thaibraille-numbering
Feb 5, 2026
Merged

Migrate Braille dot numbering to ISO/Unicode international standard#6
wannaphong merged 4 commits intomainfrom
copilot/update-thaibraille-numbering

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 5, 2026

The library used a custom dot numbering scheme incompatible with international Braille standards (EU/UK/US), preventing interoperability. This migrates to the ISO/Unicode standard where dots 1-3 occupy the left column, 4-6 the right column, and 7-8 the bottom row.

Changes

Braille Unicode mapping (Braille.db)

  • Remapped all 256 dot patterns to correct Unicode Braille characters per UTF-8 U+2800-U+28FF specification
  • Example: dot pattern "2" now maps to ⠂ (U+2802) instead of ⠈ (U+2808)

Thai character mappings

  • Systematically converted 88 Thai characters using transformation: {1→1, 2→4, 3→2, 4→5, 5→3, 6→6, 7→7, 8→8}
  • Visual Braille output unchanged; only internal representation standardized
  • Added missing characters: ฤ, ฦ, ใ, ฯ, ฯลฯ and punctuation marks

Mirror function (printbraille)

  • Updated swap logic to international standard: {1↔4, 2↔5, 3↔6, 7↔8}
# Before: custom numbering produced correct Unicode but wrong dot semantics
# After: standard numbering with same Unicode output
thai_word_braille("แมว")  # Still outputs ⠣⠍⠺, now using dots [126][134][2456]

All existing tests pass without modification.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • sr12zar.github.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Dots numbering is standardised?</issue_title>
<issue_description>The number patterns used in Thaibraille (here) seems to be unique. Internationally standardised numbering as used in EU, UK, US for 6 dots (2 columns x 3 rows) is (1:top left, 2 middle left, 3 bottom left); (4 top right, 5 mid rt, 6 bot rt) and for 8 dots the 6 dots are shifted up and 2 more dots added as bottom row with numbers (7 bot left; 8 bot rt).

Though the numbering in python code works now, there is a question on communication among international community.</issue_description>

<agent_instructions>Use Internationally standardised numbering
look https://sr12zar.github.io/KoKho/script/Th2Bn.js and https://sr12zar.github.io/KoKho/script/Bn2ThB.js</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@wannaphong I agree. Thaibraille doen't use standardised. I want to fellow Thai standardised but I don't see any standardised in my language (low resource for research), so I was create this project for create Thai Dots numbering that output is Braille Patterns block of the Unicode standard for printing.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits February 5, 2026 07:28
Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>
Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>
Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Thaibraille to use standardised numbering Migrate Braille dot numbering to ISO/Unicode international standard Feb 5, 2026
Copilot AI requested a review from wannaphong February 5, 2026 07:36
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 5, 2026

Pull Request Test Coverage Report for Build 21702878984

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.344%

Changes Missing Coverage Covered Lines Changed/Added Lines %
thaibraille/text/core.py 0 1 0.0%
Totals Coverage Status
Change from base Build 21702568635: 0.0%
Covered Lines: 71
Relevant Lines: 93

💛 - Coveralls

@wannaphong wannaphong marked this pull request as ready for review February 5, 2026 07:41
@wannaphong wannaphong merged commit e616026 into main Feb 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dots numbering is standardised?

3 participants