ENH: improve center_frequency accuracy, fix edge case
#575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In summary, below are addressed: 1. Failure to estimate center frequency within two significant figures 2. Using _negative_ frequency index if wavelet's peak frequency is positive max for even `len(psi)` Two sig figs should be bare minimum in precise frequency applications. Case (2) should be rare, but more importantly, it fails to make sense, unless I'm missing something.
|
Thanks @OverLordGoldDragon. From your StackExchange post, this looks like a nice improvement. This change will need some unit tests, possibly derived from the explanation in that post (there's no code, but there is math there that can be easily translated into code). I'm not the author of nor the expert on this code, but I'm trying to catch up on the backlog of issues and PRs about it. Will see what I can do here. |
rgommers
changed the title
center_frequency accuracy, fix edge casecenter_frequency accuracy, fix edge case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details. In summary, below are addressed:
len(psi)Two sig figs should be bare minimum in precise frequency applications. Case (2) should be rare, but more importantly, it fails to make sense, unless I'm missing something.