refactor: utils #44
Open
refactor: utils #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omplete` to `utils/public.py`
…omplete` to `utils/public.py`
* Start migration to uv * Setup ruff and hatch * Change pre-commit to use ruff * Format with ruff * Fix mistake * Add dev deps * Change workflows to use uv and ruff * ➕ Add colorlog and remove requirements folder and fix build * 💚 Fix sphinx build ? * 🐛 Add __version.py for version management and update import in __init__.py * ✏️ Update lib-checks.yml to run ruff on ubuntu-latest * 🐛 Update lib-checks.yml to run mypy with uv * 🔥 Delete MANIFEST.in * ✨ Enhance lib-checks.yml to include ruff formatter check * ♻️ Refactor pyproject.toml and uv.lock to use optional-dependencies for voice and speed
* chore: Update localization workflows to use 'uv' for dependency management * chore: refactor Read the Docs configuration to use uv
…tation to private module
It was used twice, and once it wasn't even necessary
This was referenced Aug 3, 2025
Lumabots
reviewed
Aug 3, 2025
|
I am going to close some of these comments although pertinent because this PR aims at moving code and not changing its typing. |
both could be done at the same time ig, but else when this get merged i'll make a pr fixing the typing mistake |
|
@Lumabots I am going to take all of your propositions here and make them in another or once this one is merger, just feel like this is a lot already |
Co-authored-by: Lumouille <[email protected]> Signed-off-by: Paillat <[email protected]>
Lumabots
approved these changes
Aug 4, 2025
Lumabots
reviewed
Aug 6, 2025
Icebluewolf
reviewed
Aug 6, 2025
Co-authored-by: Ice Wolfy <[email protected]> Signed-off-by: Paillat <[email protected]>
Lumabots
reviewed
Aug 6, 2025
Lumabots
reviewed
Aug 6, 2025
Lumabots
reviewed
Aug 6, 2025
Co-authored-by: Ice Wolfy <[email protected]> Co-authored-by: Lumouille <[email protected]> Signed-off-by: Paillat <[email protected]>
Co-authored-by: Lumouille <[email protected]> Signed-off-by: Paillat <[email protected]>
Co-authored-by: Lumouille <[email protected]> Signed-off-by: Paillat <[email protected]>
Signed-off-by: Paillat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general goal of these changes is to lower the amount of code we have to maintain across te library.
Changes include:
Separated utils function in:
utils.privatefor private utils that are to be used in the library codeutilsfor user facing utilsRemoved over specific utils
Removed overly specific public utils that wouldn't commonly be used by users and aren't hard to re implement in any project. See
CHANGELOG-V3.mdfor a comprehensive list.Removed unused (or lesser used) utils
Remove utils that were used less than once or twice in the library in favor of:
Merged overlapping utils
Merge utils with common goals or with same goal with one another, e.g. see changes to
utils.time_snowflake->utils.generate_snowflake