feat: ✨ add unknown sticker format type to StickerFormatType enum #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should probably just use |
|
Yeah that makes sense |
Paillat-dev
force-pushed
the
feat/unknown-sticker-format
branch
from
57fe250 to
bfd6d0b
Compare
|
This already uses try_enum wherever needed, I changed from png to None because it is better representative in my opinion |
|
i dont really get why we should use None instead of unknow. Its not really clear imo to have None as a format type |
|
So it's not the format type, it's the file extension. The format type will always be an integer, and if that integer exists in the enum it will be made into the enum with try_enum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #16