Skip to content

fix: add Member import for typehinting #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: add Member import for typehinting #2596

merged 2 commits into from
Oct 4, 2024

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Oct 4, 2024

Summary

Fixes issue introduced in #2593 causing flake8 to fail

No changelog; minor patch on a bug that doesn't affect runtime

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331
fix: add Member import
2e76b03 
Signed-off-by: plun1331 <[email protected]>
@plun1331 plun1331 requested a review from a team as a code owner October 4, 2024 18:00
@plun1331 plun1331 added bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Oct 4, 2024
@plun1331 plun1331 enabled auto-merge (squash) October 4, 2024 18:01
@plun1331 plun1331 added priority: high High Priority and removed priority: low Low Priority labels Oct 4, 2024
@plun1331 plun1331 merged commit f6b914e into master Oct 4, 2024
25 checks passed
@plun1331 plun1331 deleted the plun1331-patch-1 branch October 4, 2024 20:06
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
@plun1331 @pre-commit-ci @baribarton
fix: add Member import for typehinting (Pycord-Development#2596)
d234cd8 
* fix: add Member import

Signed-off-by: plun1331 <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Signed-off-by: plun1331 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
@plun1331 @pre-commit-ci @OmLanke
fix: add Member import for typehinting (Pycord-Development#2596)
11874a5 
* fix: add Member import

Signed-off-by: plun1331 <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Signed-off-by: plun1331 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plun1331 @Dorukyum