Skip to content

fix: sending polls with PartialWebhook #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 8, 2024
+8 −0
Merged

fix: sending polls with PartialWebhook #2624

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49b9242
fix: add store poll to webhook state
Oct 25, 2024
8e0dc29
Update CHANGELOG.md
Oct 25, 2024
8d0a6d0
Update CHANGELOG.md
Oct 25, 2024
eef5b46
Merge branch 'master' into master
tyrantlink Oct 31, 2024
6ff2126
Update CHANGELOG.md
Nov 1, 2024
db5c637
Merge branch 'master' into master
Lulalaby Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2611](https://github.com/Pycord-Development/pycord/pull/2611))
- Fixed `TypeError` when passing `skus` parameter in `Client.entitlements()`.
([#2627](https://github.com/Pycord-Development/pycord/issues/2627))
- Fixed `Webhook._WebhookState` missing `store_poll` method.
([#2624](https://github.com/Pycord-Development/pycord/pull/2624))

### Changed

Expand Down
6 changes: 6 additions & 0 deletions discord/webhook/async_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,12 @@ def create_user(self, data):
# state parameter is artificial
return BaseUser(state=self, data=data) # type: ignore

def store_poll(self, poll: Poll, message_id: int):
if self._parent is not None:
return self._parent.store_poll(poll, message_id)
# state parameter is artificial
return None

@property
def http(self):
if self._parent is not None:
Expand Down