Skip to content

Conversation

UnBonWhisky
Copy link
Contributor

Summary

Fix #2627 about the entitlements() method that raises TypeError when passing skus argument

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Signed-off-by: UnBonWhisky <[email protected]>
@UnBonWhisky UnBonWhisky requested a review from a team as a code owner October 27, 2024 18:55
@pullapprove4 pullapprove4 bot requested a review from BobDotCom October 27, 2024 18:55
@UnBonWhisky UnBonWhisky changed the title Fix TypeError when adding Fix TypeError when adding skus to entitlements() method Oct 27, 2024
@UnBonWhisky UnBonWhisky changed the title Fix TypeError when adding skus to entitlements() method fix: TypeError when adding skus to entitlements() method Oct 27, 2024
@plun1331
Copy link
Member

changelog please :3

@plun1331 plun1331 added this to the v2.7 milestone Oct 28, 2024
@plun1331 plun1331 added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer hold: changelog This pull request is missing a changelog entry labels Oct 28, 2024
Signed-off-by: plun1331 <[email protected]>
@plun1331 plun1331 requested a review from JustaSqu1d October 29, 2024 17:19
@plun1331 plun1331 enabled auto-merge (squash) October 29, 2024 17:19
@plun1331 plun1331 removed the hold: changelog This pull request is missing a changelog entry label Oct 29, 2024
@plun1331 plun1331 merged commit 05cf45e into Pycord-Development:master Oct 29, 2024
25 checks passed
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
…lopment#2628)

* Fix Pycord-Development#2627

Signed-off-by: UnBonWhisky <[email protected]>

* Update CHANGELOG.md

Signed-off-by: UnBonWhisky <[email protected]>

* Update CHANGELOG.md

Signed-off-by: UnBonWhisky <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update CHANGELOG.md

Signed-off-by: plun1331 <[email protected]>

---------

Signed-off-by: UnBonWhisky <[email protected]>
Signed-off-by: plun1331 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: plun1331 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when adding a sku in the entitlements() method
3 participants