Skip to content

fix: handle improper 1000 closures by discord #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: handle improper 1000 closures by discord #2632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e4849
Handle improper 1000 closures by Discord
Quintenvw Oct 29, 2024
6f08084
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion discord/gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,16 @@ def latency(self) -> float:

def _can_handle_close(self):
code = self._close_code or self.socket.close_code
return code not in (1000, 4004, 4010, 4011, 4012, 4013, 4014)
is_improper_close = self._close_code is None and self.socket.close_code == 1000
return is_improper_close or code not in (
1000,
4004,
4010,
4011,
4012,
4013,
4014,
)

async def poll_event(self):
"""Polls for a DISPATCH event and handles the general gateway loop.
Expand Down