Skip to content

fix: use property instead of NewType(...) to fix type annotations for ApplicationContext attributes #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 3, 2024
Merged

fix: use property instead of NewType(...) to fix type annotations for ApplicationContext attributes #2636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e5b6096
replaced NewType cached_property with functools' cached_property to f…
probablyjassin Nov 2, 2024
57b2404
Update CHANGELOG.md
probablyjassin Nov 2, 2024
a9bd1b5
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 2, 2024
0f5d52c
Update CHANGELOG.md
probablyjassin Nov 2, 2024
735de88
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 2, 2024
f72aca6
Merge branch 'master' into master
probablyjassin Nov 4, 2024
31740de
Merge branch 'master' into master
probablyjassin Nov 10, 2024
f61b889
Merge branch 'master' into master
probablyjassin Nov 14, 2024
a755821
Merge branch 'master' into master
probablyjassin Nov 21, 2024
68a3174
Merge branch 'master' into master
probablyjassin Nov 28, 2024
a750a6b
implement @DA-344's recommendation: cached_property = property
probablyjassin Nov 28, 2024
0c4a830
Merge branch 'master' into master
probablyjassin Nov 29, 2024
6a35c68
Update CHANGELOG.md
Dorukyum Dec 3, 2024
31ba9a4
Merge branch 'master' into master
Lulalaby Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2624](https://github.com/Pycord-Development/pycord/pull/2624))
- Fixed `AttributeError` when accessing `Member.guild_permissions` for user installed
apps. ([#2650](https://github.com/Pycord-Development/pycord/pull/2650))
- Fixed type annotations of cached properties.
([#2635](https://github.com/Pycord-Development/pycord/issues/2635))

### Changed

Expand Down
3 changes: 1 addition & 2 deletions discord/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
Iterator,
Literal,
Mapping,
NewType,
Protocol,
Sequence,
TypeVar,
Expand Down Expand Up @@ -151,7 +150,7 @@ def __get__(self, instance, owner):
class _RequestLike(Protocol):
headers: Mapping[str, Any]

cached_property = NewType("cached_property", property)
cached_property = property

P = ParamSpec("P")

Expand Down
Loading