Skip to content

feat: ✨ Allow changing base url with Route.API_BASE_URL #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025
Merged

feat: ✨ Allow changing base url with Route.API_BASE_URL #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
962aaf3
:sparkles: Refactor API base URL handling in Route class
Paillat-dev Feb 16, 2025
eb68ea0
:memo: CHANGELOG.md
Paillat-dev Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2579](https://github.com/Pycord-Development/pycord/pull/2579))
- Added new `Subscription` object and related methods/events.
([#2564](https://github.com/Pycord-Development/pycord/pull/2564))
- Added ability to change the API's base URL with `Route.API_BASE_URL`.
([#2714](https://github.com/Pycord-Development/pycord/pull/2714))

### Fixed

Expand Down
4 changes: 3 additions & 1 deletion discord/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ async def json_or_text(response: aiohttp.ClientResponse) -> dict[str, Any] | str


class Route:
API_BASE_URL: str = "https://discord.com/api/v{API_VERSION}"

def __init__(self, method: str, path: str, **parameters: Any) -> None:
self.path: str = path
self.method: str = method
Expand All @@ -127,7 +129,7 @@ def __init__(self, method: str, path: str, **parameters: Any) -> None:

@property
def base(self) -> str:
return f"https://discord.com/api/v{API_VERSION}"
return self.API_BASE_URL.format(API_VERSION=API_VERSION)

@property
def bucket(self) -> str:
Expand Down
Loading