Skip to content

fix: 🏷️ Fix types in Select.__init__ #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025
Merged

fix: 🏷️ Fix types in Select.__init__ #2746

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3343328
:label: Fix types in `Select.__init__`
Paillat-dev Mar 21, 2025
87ee6e3
:memo: CHANGELOG.md
Paillat-dev Mar 21, 2025
fde40ea
:memo: CHANGELOG.md changes as requestes
Paillat-dev Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2709](https://github.com/Pycord-Development/pycord/pull/2709))
- Fixed `ForumChannel.edit` allowing `default_reaction_emoji` to be `None`
([#2739](https://github.com/Pycord-Development/pycord/pull/2739))
- Fixed incorrect type hints in `Select.__init__`.
([#2746])(https://github.com/Pycord-Development/pycord/pull/2746)

### Changed

Expand Down
4 changes: 2 additions & 2 deletions discord/ui/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ def __init__(
placeholder: str | None = None,
min_values: int = 1,
max_values: int = 1,
options: list[SelectOption] = None,
channel_types: list[ChannelType] = None,
options: list[SelectOption] | None = None,
channel_types: list[ChannelType] | None = None,
disabled: bool = False,
row: int | None = None,
) -> None:
Expand Down