Skip to content

feat(loop): add optional overlap support to allow concurrent loop executions #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

feat(loop): add optional overlap support to allow concurrent loop executions #2771

wants to merge 56 commits into from
+94 −4

Conversation

Lumabots
Copy link
Contributor

@Lumabots Lumabots commented Apr 30, 2025 •
edited by Lulalaby
Loading

No description provided.

Lumabots and others added 10 commits April 18, 2025 16:44
@Lumabots
🆕 feat(loop): add optional overlap support to allow concurrent loop e…
9dc617d 
…xecutions

Added a new overlap parameter to the loop decorator and Loop class to control whether loop iterations can run concurrently. When set to True, the next iteration will not wait for the previous one to finish, allowing overlapping executions—useful for long-running tasks that should not delay subsequent runs. Defaults to False to preserve current behavior.

Signed-off-by: Lumouille <[email protected]>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
bfda3aa
@Lumabots
Update CHANGELOG.md
8dc95c4 
Signed-off-by: Lumouille <[email protected]>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
7dbf3a0
@Lumabots
Update __init__.py
1f1ef8a 
Signed-off-by: Lumouille <[email protected]>
@Lumabots
fix- TypeError: Loop.__init__() missing 1 required positional argumen…
570ae99 
…t: 'overlap'

Signed-off-by: Lumouille <[email protected]>
@Lumabots
fix cancellation using overlap=true
c8f3bb4 
Signed-off-by: Lumouille <[email protected]>
@Lumabots
fix
463a249 
Exception in callback Future.set_result(True)
handle: <TimerHandle when=203424.768941542 Future.set_result(True)>
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/asyncio/events.py", line 84, in _run
    self._context.run(self._callback, *self._args)
asyncio.exceptions.InvalidStateError: invalid state


Signed-off-by: Lumouille <[email protected]>
@Lumabots
fix identation
26a8ff1 
Signed-off-by: Lumouille <[email protected]>
@Lumabots
Merge branch 'master' into patch-2
253c67c
@Lumabots Lumabots requested a review from a team as a code owner April 30, 2025 19:30
@pullapprove4 pullapprove4 bot requested a review from Dorukyum April 30, 2025 19:30
@pullapprove4 pullapprove4 bot requested a review from Lulalaby April 30, 2025 19:30
@Lumabots
Copy link
Contributor Author

sorry i renamed the branch and it deleted the other one

@Lumabots Lumabots changed the title Overlap feat(loop): add optional overlap support to allow concurrent loop executions Apr 30, 2025
@plun1331 plun1331 mentioned this pull request May 1, 2025
Closed
9 tasks
plun1331
plun1331 previously requested changes May 1, 2025
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add an additional parameter for limiting the number of active tasks

Lumabots and others added 2 commits May 1, 2025 11:17
@Lumabots @plun1331
Update CHANGELOG.md
7e4fd6a 
Co-authored-by: plun1331 <[email protected]>
Signed-off-by: Lumouille <[email protected]>
@Lumabots @plun1331
Update discord/ext/tasks/__init__.py
1562e64 
Co-authored-by: plun1331 <[email protected]>
Signed-off-by: Lumouille <[email protected]>
@Lumabots
Copy link
Contributor Author

Lumabots commented May 1, 2025 •
edited
Loading

We should probably add an additional parameter for limiting the number of active tasks

maybe:
def init(self, ..., overlap: bool | int = True):

If overlap is:

True: allow overlapping tasks with no limit (default).

False: do not allow overlapping (wait for task to finish).

An int: allow overlapping up to n concurrent tasks.

Paillat-dev
Paillat-dev requested changes Sep 19, 2025
View reviewed changes
@Lumabots Lumabots requested a review from Soheab September 19, 2025 08:37
@Soheab
Copy link
Contributor

Soheab commented Sep 19, 2025

This could use a little example, either in the docs or in the directory. As it's asked for once in a while, and an example could help with explaining it in detail.

@Lumabots
Copy link
Contributor Author

This could use a little example, either in the docs or in the directory. As it's asked for once in a while, and an example could help with explaining it in detail.

For loop in general or mainly for overlap ?

Paillat-dev
Paillat-dev previously approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested

@Soheab
Copy link
Contributor

Soheab commented Sep 22, 2025

This could use a little example, either in the docs or in the directory. As it's asked for once in a while, and an example could help with explaining it in detail.

For loop in general or mainly for overlap ?

The latter. Like one that shows a common use case and explains it a little bit.

Paillat-dev
Paillat-dev requested changes Sep 29, 2025
View reviewed changes
Paillat-dev
Paillat-dev requested changes Sep 30, 2025
View reviewed changes
@Soheab Soheab requested a review from a team October 3, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby left review comments

Copilot code review Copilot Copilot left review comments

@Paillat-dev Paillat-dev Paillat-dev approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@plun1331 plun1331 Awaiting requested review from plun1331

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

@DA-344 DA-344 Awaiting requested review from DA-344

@Soheab Soheab Awaiting requested review from Soheab

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature Implements a feature
Projects
Pycord Releases
Status: In Progress
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
7 participants
@Lumabots @plun1331 @Lulalaby @Soheab @Paillat-dev @JustaSqu1d @DA-344