Skip to content

added back support of smile and :smile: #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 26, 2025
Merged

added back support of smile and :smile: #2822

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
78e0091
Add Unicode emoji support to PartialEmojiConverter
Lumabots Jun 25, 2025
b2a42ff
Merge branch 'revert-2814-revert-2774-emoji' of https://github.com/Py…
Lumabots Jun 25, 2025
de84bec
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 25, 2025
c7c1984
Update converter.py
Lumabots Jun 25, 2025
3d204f5
Update converter.py
Lumabots Jun 25, 2025
bbf2ed6
fix(utils): update UNICODE_EMOJIS to use values from EMOJIS_MAP
Lumabots Jun 25, 2025
926e9bb
fix(partial_emoji): simplify emoji name extraction by using removepre…
Lumabots Jun 26, 2025
c5eb334
Merge branch 'revert-2814-revert-2774-emoji' into revert-2814-revert-…
Lumabots Jun 26, 2025
3c22dee
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions discord/partial_emoji.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ def from_str(cls: type[PE], value: str) -> PE:
:class:`PartialEmoji`
The partial emoji from this string.
"""
if value.startswith(":") and value.endswith(":") and len(value) > 2:
name = value[1:-1]
if unicode_emoji := utils.EMOJIS_MAP.get(name):
return cls(name=unicode_emoji, id=None, animated=False)
value = value.removeprefix(":").removesuffix(":")
if unicode_emoji := utils.EMOJIS_MAP.get(value):
return cls(name=unicode_emoji, id=None, animated=False)

match = cls._CUSTOM_EMOJI_RE.match(value)
if match is not None:
groups = match.groupdict()
Expand Down
Loading