Skip to content

feat: Modal Selects #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
827524e
types
NeloBlivion Aug 6, 2025
48e1557
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 6, 2025
dcdea3f
component
NeloBlivion Aug 6, 2025
6e68e6a
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 6, 2025
4686ea0
items
NeloBlivion Aug 6, 2025
be6f1c0
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 6, 2025
5dd4026
Merge branch 'master' into modal_select
Lulalaby Aug 6, 2025
e76fd92
interaction._raw_data for testing
NeloBlivion Aug 6, 2025
20f1096
append
NeloBlivion Aug 7, 2025
e1c3760
move required around
NeloBlivion Aug 7, 2025
cf33b2b
raw
NeloBlivion Aug 7, 2025
132a63f
req?
NeloBlivion Aug 7, 2025
bf614aa
default required none
NeloBlivion Aug 7, 2025
20b39bf
select always uses labelcomponent
NeloBlivion Aug 7, 2025
24f018b
labels
NeloBlivion Aug 7, 2025
7dd44f5
store
NeloBlivion Aug 7, 2025
4be7d14
:=
NeloBlivion Aug 7, 2025
2c3ab0d
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 7, 2025
9a75635
again
NeloBlivion Aug 7, 2025
0ddc5d2
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 7, 2025
68ecdd4
refresh_state
NeloBlivion Aug 7, 2025
a54c449
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 7, 2025
5b53a3a
docs and limits; unsure on legacy textinput label limit
NeloBlivion Aug 7, 2025
e70b067
uses_label
NeloBlivion Aug 7, 2025
d9e6939
update limits
NeloBlivion Aug 7, 2025
db08582
Merge branch 'master' into modal_select
NeloBlivion Aug 7, 2025
a1ded7e
Update discord/ui/select.py
Lulalaby Aug 7, 2025
4455bda
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 7, 2025
0cf4938
v
NeloBlivion Aug 7, 2025
ac8b012
remove clarification
NeloBlivion Aug 7, 2025
f6b0d59
true
NeloBlivion Aug 8, 2025
64f2406
required check
NeloBlivion Aug 8, 2025
2332b87
Merge branch 'master' into modal_select
NeloBlivion Aug 12, 2025
18cf7fa
cl
NeloBlivion Aug 12, 2025
9e29a09
Update CHANGELOG.md
NeloBlivion Aug 12, 2025
7dfe5c2
Apply suggestions from code review
Lulalaby Aug 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions discord/interactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def __init__(self, *, data: InteractionPayload, state: ConnectionState):
self._from_data(data)

def _from_data(self, data: InteractionPayload):
self._raw_data: InteractionPayload = data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbf we might want to pr that to keep it not just for testing lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls

self.id: int = int(data["id"])
self.type: InteractionType = try_enum(InteractionType, data["type"])
self.data: InteractionData | None = data.get("data")
Expand Down
Loading