Skip to content

fix(views): View.message being None initially #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2025
Merged

fix(views): View.message being None initially #2916

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e16ee0b
Fix View.message being None initially
Soheab Sep 8, 2025
cca7f4f
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 8, 2025
95a16cb
chore: add changelog entry
Soheab Sep 8, 2025
8a550c0
fix: store message regardless of finished state
Soheab Sep 9, 2025
9066fc4
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 9, 2025
0c83f9a
Merge branch 'master' into fix/view-message
Soheab Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2905](https://github.com/Pycord-Development/pycord/pull/2905))
- `view=None` in various methods causing an AttributeError.
([#2915](https://github.com/Pycord-Development/pycord/pull/2915))
- `View.message` being `None` when it had not been interacted with yet.
([#2916](https://github.com/Pycord-Development/pycord/pull/2916))

### Removed

Expand Down
16 changes: 9 additions & 7 deletions discord/interactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,7 +1030,7 @@ async def send_message(

flags = MessageFlags(ephemeral=ephemeral)

if view is not None:
if view:
payload["components"] = view.to_components()
if view.is_components_v2():
if embeds or content:
Expand Down Expand Up @@ -1100,16 +1100,18 @@ async def send_message(
for file in files:
file.close()

if view is not None:
self._responded = True
await self._process_callback_response(callback_response)
if view and not view.is_finished():
if ephemeral and view.timeout is None:
view.timeout = 15 * 60.0

view.parent = self._parent
if view.is_dispatchable():
self._parent._state.store_view(view)

self._responded = True
await self._process_callback_response(callback_response)
view.message = await self._parent.original_response()

if delete_after is not None:
await self._parent.delete_original_response(delay=delete_after)
return self._parent
Expand Down Expand Up @@ -1268,12 +1270,12 @@ async def edit_message(
for file in files:
file.close()

self._responded = True
await self._process_callback_response(callback_response)
if view and not view.is_finished():
view.message = msg
view.message = msg or await parent.original_response()
state.store_view(view, message_id)

self._responded = True
await self._process_callback_response(callback_response)
if delete_after is not None:
await self._parent.delete_original_response(delay=delete_after)

Expand Down
Loading