-
-
Notifications
You must be signed in to change notification settings - Fork 483
fix: 🐛 Remove old code that only applies for bot guild owners (not possible anymore) #3056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: 🐛 Remove old code that only applies for bot guild owners (not possible anymore) #3056
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3056/head:pr-3056
git checkout pr-3056This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3056/head |
|
can you also check if we have references to create guild anywhere? |
Seems to be quite a few, I'll get on it. I probably missed delete stuff there too |
Lulalaby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️
Paillat-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| - Removed the `owner` keyword argument from `Guild.edit` as this requires owner | ||
| permissions ([#3056](https://github.com/Pycord-Development/pycord/pull/3056)) | ||
| - Removed `Template.create_guild` and `Client.create_guild` as bots can no longer create | ||
| guilds ([#3056](https://github.com/Pycord-Development/pycord/pull/3056)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we maybe want to be more explicit with the fact that this was removed by Discord themselves ? I personally don't really care either ways.
Summary
Removes some code that only worked when owners were able to own guilds, since this is no longer the case, the code is now effectively dead
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.