fix: Remove incorrect 8-byte stripping in AEAD rtpsize decryption #3060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_decrypt_aead_xchacha20_poly1305_rtpsize` function was incorrectly stripping 8 bytes from the decrypted audio data. This corrupts the opus stream because the first byte is the opus TOC (Table of Contents) byte. Testing results: - With 8-byte stripping: ~80% decode success, 600+ audio clicks/second - Without stripping: 100% decode success, 0 audio clicks The decrypted data is the opus packet directly - the first byte (e.g., 0x7c) is a valid opus TOC byte indicating config=15 stereo audio. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3060/head:pr-3060
git checkout pr-3060This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3060/head |
Member
|
Hi, thank you for your pull request. Could you please provide clear and explicit reproduction steps AND code for this problem and open a related issue ? Thank you |
Paillat-dev
added
voice
Member
|
This is incorrect according to discord docs and other library's implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes opus decode failures caused by incorrect 8-byte stripping in
_decrypt_aead_xchacha20_poly1305_rtpsize.PR #2925 added code to strip 8 bytes from decrypted audio data, but this corrupts the opus stream because the first byte is the opus TOC (Table of Contents) byte.
Testing Results
Technical Details
0x7c) is a valid opus TOC byte indicating config=15 stereo audioOpusError: corrupted streamTest Methodology
start_recording()Environment
aead_xchacha20_poly1305_rtpsize🤖 Generated with Claude Code