-
Notifications
You must be signed in to change notification settings - Fork 47
Add more granular solver specs #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds helper utilities to define/apply more granular (per-spoke) solver configuration, including per-iteration mipgap settings, and wires these into several spokes.
Changes:
- Refactors solver spec config creation into
add_solver_specs()and newadd_mipgap_specs()helpers. - Introduces
apply_solver_specs()to apply per-spoke solver name/options/mipgap overrides when building spoke dictionaries. - Updates multiple spokes to use the shared helpers instead of inline mipgap wiring.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mpisppy/utils/config.py | Adds reusable config helpers for solver + mipgap specs and applies them across spokes. |
| mpisppy/utils/cfg_vanilla.py | Adds apply_solver_specs() and simplifies _hasit (currently with a behavior-changing bug). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
DLWoodruff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
mpisppy/utils/solver_spec.py:73
- If no solver name is found and
name_required=False, this function will fall through and returnsolver_name/solver_optionswithout them ever being initialized, leading to anUnboundLocalError. Initialize them before the loop (e.g., toNone/{}) and return those defaults when no match is found.
solver_options = sputils.option_string_to_dict(ostr)
break
else:
if name_required:
# Leaving in underscores even though it might confuse command line users
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit e3373ab.
Thanks, although I'm having trouble resolving some issues in the confidence interval code. If I don't get back to this, it would be a good topic for a future call. |
No description provided.