Skip to content

[Xpress] Remove deprecation warnings (#1) #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blnicho merged 18 commits into from
Feb 18, 2026
Merged

[Xpress] Remove deprecation warnings (#1) #3794

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9ab1283
Remove deprecation warnings (#1)
XPRSc4v4 Dec 4, 2025
13ee044
Merge branch 'main' into main
XPRSc4v4 Dec 5, 2025
d694eb2
Merge branch 'main' of https://github.com/Pyomo/pyomo
XPRSc4v4 Dec 17, 2025
3675141
Merge branch 'main' of https://github.com/XPRSc4v4/pyomo
XPRSc4v4 Dec 17, 2025
1e1cd59
Removed very old version handling + added workflow test for 9.3
XPRSc4v4 Dec 17, 2025
f78123b
Workflow fix
XPRSc4v4 Dec 19, 2025
427f306
Merge branch 'main' into main
blnicho Jan 13, 2026
0236606
Merge branch 'main' into main
blnicho Jan 19, 2026
8878a96
Merge branch 'main' into main
blnicho Jan 22, 2026
1225942
Change GHA logic for testing old Xpress version
blnicho Jan 23, 2026
d0d9b41
Add 'intel' channel to conda configuration
blnicho Jan 23, 2026
ca192fe
Adjust which GHA jobs test older Xpress version
blnicho Jan 23, 2026
b36bace
Merge branch 'main' into main
mrmundt Jan 27, 2026
72a1258
Adjust which GHA jobs test old Xpress version
blnicho Feb 3, 2026
91b8daf
Merge branch 'main' into main
blnicho Feb 3, 2026
d9a3300
Merge branch 'main' into main
jsiirola Feb 4, 2026
2121e59
Revert changes to GHA workflow
blnicho Feb 4, 2026
869e669
Merge branch 'main' into main
blnicho Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_pr_and_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ jobs:
TIMEOUT_MSG="TIMEOUT: killing conda install process"
PYVER=$(echo "py${{matrix.python}}" | sed 's/\.//g')
echo "Installing for $PYVER"
for PKG in 'cplex>=12.10' docplex gurobi "$XPRESS" cyipopt pymumps scip; do
for PKG in 'cplex>=12.10' docplex gurobi "$XPRESS" 'xpress<9.3' cyipopt pymumps scip; do
Copy link
Member

@blnicho blnicho Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing the xpress version for every GHA job using conda to install Python packages which is not what I think you intended. During the dev call we talked about installing an older version of xpress on just one or two jobs to exercise the version-specific logic in the solver interface. I think you can do this by modifying the if-tree above that sets the XPRESS environment variable. There is already some special logic there for windows so maybe we use the linux conda job for this. I think you can just modify the else section on line 450 to something like:

if test "${{matrix.TARGET}}" == linux; then
    XPRESS='xpress<9.3'
else
    XPRESS='xpress'
fi

Copy link
Contributor Author

@XPRSc4v4 XPRSc4v4 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have asked for clarification during the call!
I've applied the changes, targeting Python 3.10 so the latest Xpress release is still tested in the other jobs. Let me know if there are any other issues.

Copy link
Member

@blnicho blnicho Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So turns out we can't use the Linux conda job to test an older version of Xpress because we can't get ANY version of Xpress to install in our Linux/conda GHA job. I tried both Python 3.11 and 3.12. They fail saying the environment can't be satisfied because intel-openmp can't be found in our conda channels. I modified the workflow to try using the win/3.10 and win/3.11 jobs instead.

Copy link
Contributor Author

@XPRSc4v4 XPRSc4v4 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Bethany. Let me know if there is anything I could do to help!

Copy link
Member

@blnicho blnicho Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our conda environments are fragile on GHA so I switched to using the linux/3.10 and linux/3.11 jobs for this which install Xpress using pip. I'll mark this discussion as resolved once I verify that the right versions of Xpress were installed.

echo ""
echo "*** Install $PKG ***"
echo ""
Expand Down
Loading