Skip to content

Conversation

@eminyouskn
Copy link
Contributor

Fixes # .

Summary/Motivation:

This PR add two tests to verify if the extra_info attribute of the results has been correctly populated with the expected info.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, good catch on all of this.

@mrmundt
Copy link
Contributor

mrmundt commented Jan 23, 2026

Also, totally a joke, @eminyouskn , but we were trying to get to one page of PRs today!! UGH! 😜

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.45%. Comparing base (b404bca) to head (0db0118).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3824   +/-   ##
=======================================
  Coverage   89.44%   89.45%           
=======================================
  Files         905      905           
  Lines      105485   105485           
=======================================
+ Hits        94355    94357    +2     
+ Misses      11130    11128    -2     
Flag Coverage Δ
builders 29.13% <0.00%> (-0.01%) ⬇️
default 86.07% <100.00%> (?)
expensive 35.76% <0.00%> (?)
linux 86.76% <0.00%> (-2.46%) ⬇️
linux_other 86.76% <0.00%> (+<0.01%) ⬆️
osx 82.91% <0.00%> (ø)
win 84.98% <0.00%> (ø)
win_other 84.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrmundt mrmundt merged commit 9702ff1 into Pyomo:main Jan 23, 2026
61 of 65 checks passed
@eminyouskn eminyouskn deleted the knitro-noitercount-for-mip branch January 23, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants