-
-
Notifications
You must be signed in to change notification settings - Fork 168
Refresh token if it will likely expire before the next validation #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
EvieePy
merged 9 commits into
PythonistaGuild:main
from
bartmoorman:refresh-token-if-expires-before-next-validation
Mar 22, 2025
Merged
Refresh token if it will likely expire before the next validation #487
EvieePy
merged 9 commits into
PythonistaGuild:main
from
bartmoorman:refresh-token-if-expires-before-next-validation
Mar 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore-next-validation
…ore-next-validation
EvieePy
requested changes
Mar 22, 2025
Member
|
I've added some additional logic to the tokens.py file, you will have to validate there is no conflicts with your logic. |
Contributor
Author
Thank you for the heads up. I don't see any logic conflicts between the changes. |
EvieePy
requested changes
Mar 22, 2025
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves 2 issues:
_revalidate_all'sexpires_incheck from 300 seconds to 3600 seconds (added a 5 minute buffer) since the time between token validations is 55 minutes.expires_incheck toadd_token. If the token will expire before the next validation (55 minutes + 5 minute buffer), refresh the token before adding it.Logs showing changes are working as intended:
Checklist