Skip to content

Migrated to flutter bloc package for receptions screen and added options to filter the appointments#30

Open
dhushyanth-s wants to merge 17 commits intoaptmtfrom
dhushyanth
Open

Migrated to flutter bloc package for receptions screen and added options to filter the appointments#30
dhushyanth-s wants to merge 17 commits intoaptmtfrom
dhushyanth

Conversation

@dhushyanth-s
Copy link
Contributor

  1. Migrated to flutter bloc package for the screen of the receptions
  2. Added options to filter appointments as per your convenience
  3. Added buttons to close, open and delete receptions easily
  4. Added pull-to-refresh functionality in receptions screen

Copy link
Member

@piyushchauhan piyushchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bloc is not functioning properly. It is getting stuck after status update requested.

void initState() {
receptionsBloc = ReceptionsBloc(selectedDate);
receptionsBloc.date = selectedDate;
_tabController = TabController(length: 4, vsync: this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are not tabs no need of this.

counter: "UPCOMING",
),
),
FilterChip(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a common widget so that the code is not so redundant.

@piyushchauhan piyushchauhan self-requested a review November 8, 2020 07:08
Copy link
Member

@piyushchauhan piyushchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Btn visibility logic (sent on whatsapp)

  2. At once only 1 chip should be selected. By default Upcoming chip should be selected whenever the app loads.

Copy link
Member

@piyushchauhan piyushchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Change the color of enabled buttons to theme colors.
  2. Update the error response. There are jsons coming in the views.
    Rest all is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants