Fix for missing choice.exe on XP#25
Open
brickviking wants to merge 7 commits intoQB64Official:masterfrom
Open
Conversation
If we're running on XP, add the insecure switch to curl You may also need this for Vista
Author
|
We seem to have run into an obstacle for XP, that it can't successfully negotiate a secure connection to github, because the OS only supports TLS1.0 at the latest. There is an unverified way to get TLS1.1/1.2 installed along with Internet Explorer 8, but man, that's a long winded way of getting qb64 onto a system. |
Minimal change just to get Github's CI to pass a build. Signed-off-by: Brickviking <brickviking@gmail.com>
|
I think the idea is pretty good, but I would suggest that we create a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes here, one to work around the missing
CHOICE.EXEcommand on XP, the other to prepare for a possible "wait until file downloads before we unarchive it" change.I'm after some help here, is there a way of platform-independently waiting for a set amount of time on Windows XP? So far the only options I've seen for waiting have used
timeout, which doesn't exist on XP, or ping, which is ugly, but does work as long as the machine has networking up. I only really need it to fetch the initial curl cab file by using Internet Explorer to download the file, as every version from 10 onwards appears to have curl.exe already installed as part of the base operating system files.