Skip to content

Comments

Drop unnecessary Hasher::finish() in AssetBase::hash#219

Merged
PaulLaux merged 1 commit intozcash_pr471_reviewfrom
drop_assetbase_hash_finish
Feb 11, 2026
Merged

Drop unnecessary Hasher::finish() in AssetBase::hash#219
PaulLaux merged 1 commit intozcash_pr471_reviewfrom
drop_assetbase_hash_finish

Conversation

@dmidem
Copy link

@dmidem dmidem commented Jan 11, 2026

This PR removes the h.finish(); line in src/note/asset_base.rs (AssetBase::hash) because it does nothing useful there and it generates the unused_must_use compilation warning when compiling Orchard as a librustzcash dependency:

Checking orchard v0.11.0 (/home/dima/devel/qedit/zsa/orchard)
warning: unused return value of `finish` that must be used
   --> /home/dima/devel/qedit/zsa/orchard/src/note/asset_base.rs:149:9
    |
149 |         h.finish();
    |         ^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
149 |         let _ = h.finish();
    |         +++++++

warning: `orchard` (lib) generated 1 warning

@PaulLaux PaulLaux changed the base branch from zsa1 to zcash_pr471_review January 29, 2026 09:02
@PaulLaux PaulLaux force-pushed the drop_assetbase_hash_finish branch from 18dd556 to 517818e Compare January 29, 2026 09:03
@PaulLaux PaulLaux merged commit 6a0adc1 into zcash_pr471_review Feb 11, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants