PR471 review: Add AssetId enum#223
Merged
ConstanceBeguier merged 8 commits intozcash_pr471_reviewfrom Jan 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the following review comments:
r2550373804
r2550386724
r2550403709
Introduce the AssetId enum holding an ik and an asset_desc_hash, and use it as input for encode_asset_id, asset_digest, and AssetBase::custom (renamed from AssetBase::derive).
AssetId uses lifetimes to borrow ik and avoid cloning it.