PR471: Make rho optional in Note#226
Merged
ConstanceBeguier merged 3 commits intozcash_pr471_reviewfrom Jan 15, 2026
Merged
Conversation
When creating an issuance note, the rho value is initaliazed with None. This value will be set when calling `update_rho` method on the `IssueBundle`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the following review comments:
r2543612212
r2543614980
When creating an issuance note, the rho value is now initialized to None (instead of being set to 0 previously).
The rho value is later deterministically derived and assigned when calling the
update_rhomethod on theIssueBundle.In addition, this PR fixes an issue where issuance notes could be invalid. Previously, rseed was sampled before the final rho value was known, which could result in an invalid note. With this change, rseed is updated after rho is set, ensuring that the resulting note is always valid.