PR471 review: Fix issuance key derivation to use dedicated ZIP-32 context#229
Merged
ConstanceBeguier merged 3 commits intozcash_pr471_reviewfrom Jan 19, 2026
Merged
PR471 review: Fix issuance key derivation to use dedicated ZIP-32 context#229ConstanceBeguier merged 3 commits intozcash_pr471_reviewfrom
ConstanceBeguier merged 3 commits intozcash_pr471_reviewfrom
Conversation
ConstanceBeguier
force-pushed
the
pr471_isk
branch
from
bee0ef4 to
c9364d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the following review comments:
r2542655700
r2542668676
This PR introduces a dedicated ZIP-227 issuance key derivation using hardened-only ZIP-32, separate from Orchard spending keys.