Address review comments from zcash PR #471 (2)#243
Merged
ConstanceBeguier merged 5 commits intozsa1from Mar 6, 2026
Merged
Conversation
ConstanceBeguier
changed the title
ConstanceBeguier
force-pushed
the
Orchard_ZSA_review_2
branch
from
0e0e38c to
9e4a166
Compare
PaulLaux
approved these changes
Mar 5, 2026
Collaborator
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
looks good
Also please fix: src/issuance.rs:832 "the requested IssueAction not exists in the bundle." should be "does not exist"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the second round of review feedback.