Add IssueBundle::note_commitments to expose extracted note commitments#245
Merged
Add IssueBundle::note_commitments to expose extracted note commitments#245
Conversation
PaulLaux
reviewed
Mar 29, 2026
Collaborator
PaulLaux
left a comment
There was a problem hiding this comment.
Looks good, but a possitive+negative(empty bundle) test is required to finilize. For possitive test, you can add it to the big "happy flow" test if possible.
Author
Done. I added a positive test for |
PaulLaux
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
IssueBundle::note_commitments()to expose extracted note commitments directly aspallas::Basevalues.This is useful in Zebra to recompute issuance-related commitments without the current
to_bytes/from_bytesworkaround:https://github.com/QED-it/zebra/blob/2634fd662a4eaca6df901c82b1bc05d2982636d7/zebra-chain/src/orchard_zsa/issuance.rs#L43
See also the related Zebra PR review comment:
QED-it/zebra#111 (comment)