Conversation
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Overall good. added some comments.
Also, need to find a way not to trigger the CI when the zsa1 is submitted as a PR to the Upstream Zebra.
For example we have the Upstream PR:
ZcashFoundation#9560
We don't want out flows to trigger the upstream zebra CI, at all.
Not sure I understood- what CI pipeline? And what is the case it is triggered? |
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
added minor comments. Let's discuus tommorow which branch to target.
.github/workflows/push-ecr.yaml
Outdated
| env: | ||
| AWS_REGION: ${{ vars.AWS_REGION || 'eu-central-1' }} | ||
| ECR_REPOSITORY: ${{ vars.ECR_REPOSITORY || 'dev-zebra-server' }} | ||
| DOCKERFILE_PATH: testnet-single-node-deploy/dockerfile |
There was a problem hiding this comment.
${{ vars. for testnet-single-node-deploy in all places
2 participants
Update the current workflows notes that it's only for pushing a new image to ECR.
Add also the ability to add a free-text docker image tag, and add a tag from the GIT tag of that branch.
Add another workflow to update the ECS service to use a docker image tag of the users free-text selection in that workflow.