COMP: Fix Windows build error

[lassoan]

By default, windows.h adds macros "min" and "max", which interfere with other "max" symbols (e.g., in numeric_limits::max, max in vnl_sse.h). If "NOMINMAX" is defined before including windows.h then the min and max macros do not get defined.

ITK headers include NOMINMAX before including windows.h, therefore we include an ITK header before using DCMTK to ensure that min and max macros are not added, avoiding any name clash.

[lassoan]

The CI error seems a false alarm to me. mkdir should get -p argument so that it does not return with error when the build folder already exists (probably due to successful caching).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[fedorov]

@lassoan I am curious - why did you remove this decorator?

[lassoan]

The export directive is only needed if the target is built as a shared library. This is built as a static library, so export directive is not necessary. Moreover, this export directive is just copied from somewhere, probably from a DCMTK example, so having it here would have made the build fail.

[fedorov]

Thank you Andras! Yes, likely this was just copied from DCMTK when @michaelonken wrote this class.

[michaelonken]

The export directive is only needed if the target is built as a shared library. This is built as a static library, so export directive is not necessary. Moreover, this export directive is just copied from somewhere, probably from a DCMTK example, so having it here would have made the build fail.

Yes exactly, it was accidentally copied from DCMTK. Its not required within dcmqi code.

Thanks for support Andras!