Skip to content

Backend code cleanup#24

Open
BrookJeynes wants to merge 7 commits intomainfrom
code-cleanup
Open

Backend code cleanup#24
BrookJeynes wants to merge 7 commits intomainfrom
code-cleanup

Conversation

@BrookJeynes
Copy link
Contributor

No description provided.

## Notes
- User and Unit models refactored
- wip: separating function responsibilities
@BrookJeynes BrookJeynes requested a review from rjboas January 4, 2023 02:24
## Notes
- Moved DB related functions to the Infrastructure layer
- Ensured Application layer returns data and is serialised by the Api layer
Copy link
Contributor

@rjboas rjboas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made some comments on some code patterns that could possibly be tidied up but the logic seems fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants