try fix types constraints #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qazalbash
reviewed
Oct 21, 2025
Comment on lines
+356
to
+358
| base_constraint: ConstraintT | ||
| reinterpreted_batch_ndims: int | ||
|
|
Owner
There was a problem hiding this comment.
I would prefer a factory function over these changes. What are your thoughts?
Comment on lines
+43
to
+54
| # ConstraintLike represents any constraint object (both Constraint[NumLike] and | ||
| # Constraint[NonScalarArray]). We use Any because: | ||
| # 1. Constraint[T] is a generic class, and mypy struggles with Protocol subtyping | ||
| # of generic classes due to variance issues | ||
| # 2. Some constraints only accept NonScalarArray while others accept full NumLike, | ||
| # making a single Protocol definition either too restrictive or too permissive | ||
| # 3. Creating a structural Protocol causes mypy errors when assigning concrete | ||
| # constraint instances to protocol-typed variables | ||
| # At runtime, all constraints share the interface (is_discrete, event_dim, __call__, etc.) | ||
| # and work correctly. This type alias provides better documentation than raw `Any` | ||
| # while acknowledging the limitations of Python's type system for this use case. | ||
| ConstraintLike: TypeAlias = Any |
Owner
There was a problem hiding this comment.
Isn't this defeating the purpose of why we are introducing the types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a rather pragmatic suggestion since its hard to make it work