Open
Conversation
QiliangCui
reviewed
Nov 17, 2025
cases/hourly_disagg.csv
Outdated
| @@ -1,2 +1,6 @@ | |||
| Device,Model,MaxNumSeqs,MaxNumBatchedTokens,TensorParallelSize,MaxModelLen,Dataset,InputLen,OutputLen,ExpectedETEL,NumPrompts | |||
| v6e-8,meta-llama/Llama-3.1-8B-Instruct,128,1024,2,2048,sonnet,1800,128,,1000 | |||
| Device,Model,MaxNumSeqs,MaxNumBatchedTokens,TensorParallelSize,MaxModelLen,Dataset,InputLen,OutputLen,ExpectedETEL,NumPrompts,RequestRate | |||
Owner
There was a problem hiding this comment.
the code now can't be smart enough to find "RequestRate" in this case... the first line is just CSV header, in your case, this needs to be
Device,Model,MaxNumSeqs,MaxNumBatchedTokens,TensorParallelSize,MaxModelLen,Dataset,InputLen,OutputLen,ExpectedETEL,NumPrompts,MODELTAG,PREFIX_LEN,RequestRate
here https://github.com/QiliangCui/bm-infra/blob/main/scripts/scheduler/schedule_run.sh#L48 is how it is read
QiliangCui
approved these changes
Nov 21, 2025
patemotter
reviewed
Nov 25, 2025
Collaborator
patemotter
left a comment
patemotter
left a comment
There was a problem hiding this comment.
Overall LGTM, the only real issue is whether or not the ExtraEnvs logic does things in a way that we need to move your new entry before it.
| @@ -1,2 +1,6 @@ | |||
| Device,Model,MaxNumSeqs,MaxNumBatchedTokens,TensorParallelSize,MaxModelLen,Dataset,InputLen,OutputLen,ExpectedETEL,NumPrompts | |||
| v6e-8,meta-llama/Llama-3.1-8B-Instruct,128,1024,2,2048,sonnet,1800,128,,1000 | |||
Collaborator
There was a problem hiding this comment.
Nit: Was this entry meant to be deleted?
v6e-8,meta-llama/Llama-3.1-8B-Instruct,128,1024,2,2048,sonnet,1800,128,,1000
Author
There was a problem hiding this comment.
Yes, we want to test more using mlperf. This is too prefill-heavy.
patemotter
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.