Skip to content

Conversation

abbycross
Copy link
Collaborator

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@abbycross
Copy link
Collaborator Author

abbycross commented Oct 7, 2025

Unsure why the ./check asked me to add /index to the end of the /docs/guides link in the _toc file. (Errored, saying it could not find the file in the toc)
UPDATE: the check assumes that the index file is always the first in the toc. We want it to be in this case, so moving Quick start to the second entry will fix the error here.

"id": "9a3180c2-56d7-4224-91fa-13d8cb87d93d",
"metadata": {},
"source": [
"The expected output is a near-even split between '00' and '11'."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to explain how to interpret the output? Where the 505 and 519 came from and what they mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on this. I agree that this gives no explanation or context, which I'm naturally uncomfortable with - but in trying to capture the intention of a quick-start, I'm letting this be a teaser to spark interest (we should of course link out to learn more, but not explain on this page).

"id": "738d4fc4-29c9-46ab-9879-3365e2149d04",
"metadata": {},
"source": [
"This result is a signature of quantum entanglement.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"This result is a signature of quantum entanglement.\n",
"This result, where the two bars are almost the same height, is a signature of quantum entanglement.\n",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more complex than this, right, and has to do with correlation? Again, I think we can't reasonably explain these things in a quick-start guide without weighing it down, and should link out instead. Where to link out to is a bigger question - our learning materials, or some quick and dirty definition of entanglement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants