-
Notifications
You must be signed in to change notification settings - Fork 158
Add dynamic circuit tutorial #4368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@miamico is this ready content-wise for review? I can help with getting this to pass all the checks if so. |
|
@abbycross sorry to get back to you just now. Let me and Nate have a look over the latest version of the tutorial and then it should be good to go to you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Here's some comments on this version:
- edit the "usage estimate" line. I think we don't say the specific processor anymore but something like "Usage estimate: 7.5 minutes on a Heron r3 processor."
- I would emphasize the fact that we are using dynamic circuits to implement interactions that go beyond the physical connectivity of the device. It took me a couple reading of the introduction to get it. Not sure whether also edit the title but for sure highlighting it in the introduction a bit more and earlier on
- Review the standard naming of the various Step .. sections, I think there's some discrepancies with existing tutorials
- The final plot is a little crowded. Let's use the following conventions: simulations (solid lines) experimental data (scatter plots with different markers and error bars). That hopefully cleans it up a bit
No description provided.