-
Notifications
You must be signed in to change notification settings - Fork 161
include matplotlib.pyplot as plt, and updates to guides to help with translating plural object names #4447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code: |
…4421) In the documentation, multiple objects of a class were sometimes referred to using the style "`MyClass`s". This PR updates these references to "`MyClass` objects" to fix translation problems in documentation. This addresses the part of #2067 for `/guides`. --------- Co-authored-by: abbycross <[email protected]>
Eric-Arellano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you change the PR title to mention the "objects"? Also apply Eric's comment about the extra space: #4447 (comment)
Co-authored-by: Eric Arellano <[email protected]>
frankharkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes #4437
Also brings in changes by external contributor in #4421 - including here so that checks will pass