Expire PR previews based on PR activity #4481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
previously approved these changes
Jan 7, 2026
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Thanks!
Feel free to push back, but I think this might be worth doing: the logic is fairly complex for get_pr_folders. Consider unit testing it. I'd recommend refactoring it so that the run_subprocess isn't part of the test, since that's non-deterministic.
Co-authored-by: Eric Arellano <[email protected]>
frankharkins
commented
Jan 12, 2026
|
|
||
| parsed = json.loads(api_response, object_hook=parse_updated_at) | ||
| all_pr_numbers = (number for number in parsed) | ||
| all_pr_numbers = (pr["number"] for pr in parsed) |
Member
Author
There was a problem hiding this comment.
Good thing you suggested tests – this wasn't caught by the type checker because parsed is Unknown
Eric-Arellano
previously approved these changes
Jan 12, 2026
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Thanks for writing tests!
Co-authored-by: Eric Arellano <[email protected]>
Eric-Arellano
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PR expiration logic looks at the time PR files were last modified. This PR switches the check to look at the time the PR was last updated. This could be a better metric in cases where the PR is undergoing a long review.