-
Notifications
You must be signed in to change notification settings - Fork 167
updated time evolution circuit to match hamiltonian. Re-ran. #4627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 One or more of the following people are relevant to this code: |
learning/courses/quantum-diagonalization-algorithms/krylov.ipynb
Outdated
Show resolved
Hide resolved
learning/courses/quantum-diagonalization-algorithms/krylov.ipynb
Outdated
Show resolved
Hide resolved
jlapeyre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This correction needed to be made. I commented on a few places where the same change needs to be made in the text.
learning/courses/quantum-diagonalization-algorithms/krylov.ipynb
Outdated
Show resolved
Hide resolved
learning/courses/quantum-diagonalization-algorithms/krylov.ipynb
Outdated
Show resolved
Hide resolved
learning/courses/quantum-diagonalization-algorithms/krylov.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: John Lapeyre <[email protected]>
jlapeyre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Below, I have one question. And I added a comma in a "suggestion"
learning/courses/quantum-diagonalization-algorithms/krylov.ipynb
Outdated
Show resolved
Hide resolved
| "# backend = service.backend(\"ibm_torino\")" | ||
| "# backend = service.least_busy(operational=True, simulator=False)\n", | ||
| "service = QiskitRuntimeService(channel=\"ibm_quantum_platform\")\n", | ||
| "backend = service.backend(\"ibm_fez\")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be set to least_busy again?
Co-authored-by: John Lapeyre <[email protected]>
Fixes #4589