Skip to content

Added support for the new channel#53

Merged
Tansito merged 6 commits intomainfrom
support-new-channel
Jun 17, 2025
Merged

Added support for the new channel#53
Tansito merged 6 commits intomainfrom
support-new-channel

Conversation

@Tansito
Copy link
Member

@Tansito Tansito commented Jun 12, 2025

Summary

This PR is related with the work being done here: Qiskit/qiskit-serverless#1657

It enables the usage of ibm_quantum_platform as value for the channel.

@Tansito Tansito marked this pull request as ready for review June 16, 2025 18:34
requirements.txt Outdated
certifi>=2021.5.30
importlib_metadata>=4.8.1
qiskit_serverless>=0.23.0, <0.24.0
qiskit_serverless @ git+https://github.com/Qiskit/qiskit-serverless.git@main#subdirectory=client
Copy link
Member Author

@Tansito Tansito Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to change it to be able to test the feature from main. Before merge I will return to the correct value.

matrix:
os: [ubuntu-latest]
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.10', '3.11', '3.12', '3.13']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for #54 before merge this.

@Tansito Tansito requested review from ElePT, korgan00 and paaragon June 16, 2025 18:35
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided #54 merges and the comments are addressed. Thanks for doing this!

Comment on lines +27 to +28
# - os: windows-latest
# python-version: 3.11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#54 should allow these tests to run properly, let's remember to remove the comment

Tansito added 2 commits June 17, 2025 16:12
# Conflicts:
#	.github/workflows/test_latest_versions.yml
#	requirements.txt
@Tansito Tansito merged commit 8b62bdb into main Jun 17, 2025
11 checks passed
@Tansito Tansito deleted the support-new-channel branch June 17, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants