Fix jobs methods to use function filter correctly#76
Conversation
148c647 to
8611a03
Compare
… into distict files to reflect file structure in the catalog. Split tests by tested functionality.
8611a03 to
ca66bd1
Compare
jobs methods to use new filtersjobs methods to use function filter correctly
HuangJunye
left a comment
There was a problem hiding this comment.
Everything looks very clear and correct to me. However, I am not very familiar with mocking test so I can't be certain that everything is ok so I am leaving only a comment not an approval.
I was a bit confused at first why test_catalog.py and test_serverless.py are so similar, but it just reflects again that there are two many similar classes and we need to refactor to simplify things.
We could definitely work on a testing mixer or something of the sorts to avoid code repetition, but to be honest, with 2 tests I didn't want to over-engineer it. In the end, as you said, this reflects the fact that we are not taking advantage of inheritance to speed up development or testing, and we need to keep testing every component independently. |
Hi. The EDIT: Nevermind. I thought the |
Summary
This PR addresses a discrepancy in the arguments of the
jobsmethod compared toIBMServerlessClient. In order to be able to test the fix, this PR also includes a quick refactoring of the unit tests, including:testto follow qiskit standardsDetails and comments