Skip to content

Fix readme link#77

Merged
ElePT merged 2 commits intomainfrom
fix-readme
Feb 6, 2026
Merged

Fix readme link#77
ElePT merged 2 commits intomainfrom
fix-readme

Conversation

@ElePT
Copy link
Collaborator

@ElePT ElePT commented Feb 6, 2026

Summary

Closes #55.

Details and comments

@ElePT ElePT requested a review from a team as a code owner February 6, 2026 10:44
Copy link
Contributor

@HuangJunye HuangJunye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I left a comment suggesting to use relative link instead of absolute url.

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
@ElePT ElePT requested a review from HuangJunye February 6, 2026 12:07
Copy link
Contributor

@HuangJunye HuangJunye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HuangJunye HuangJunye added this pull request to the merge queue Feb 6, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2026
* Update README.md

* Update README.md

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>

---------

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 6, 2026
@HuangJunye HuangJunye added this pull request to the merge queue Feb 6, 2026
@HuangJunye
Copy link
Contributor

@ElePT Not sure why the CI checks didn't run. I added to merge queue again.

@HuangJunye HuangJunye removed this pull request from the merge queue due to a manual request Feb 6, 2026
@HuangJunye
Copy link
Contributor

I think we need to add merge_group to all workflows in order for them to be triggered in merge queue, according to the doc: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

Is the merge queue option enabled only recently?

@HuangJunye
Copy link
Contributor

I opened an PR #80 to add merge_group to all relevant workflows.

@ElePT ElePT added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit e249814 Feb 6, 2026
11 checks passed
@HuangJunye HuangJunye deleted the fix-readme branch February 10, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tutorial link on README is broken

2 participants