Add tests installing serverless from source#89
Conversation
HuangJunye
left a comment
HuangJunye
left a comment
There was a problem hiding this comment.
Looks good to me. Just a small comment for removing py39 in
Line 3 in 6d3faab
| strategy: | ||
| max-parallel: 4 | ||
| matrix: | ||
| python-version: ['3.10', '3.13'] |
There was a problem hiding this comment.
Looks good to me. I have a small question, the line 27 defines other python versions python-version: ['3.10', '3.11', '3.12', '3.13'], shouldn't it also be the case here?
There was a problem hiding this comment.
I didn't want to add the load of 4 more tests to the CI workers, so I settled with 2 (oldest and newest python). Given how quick tests are we could do 4, if you think that's relevant.
There was a problem hiding this comment.
@ElePT Do you want to add tests for other versions of python or as is? I don't have strong feelings about it.
There was a problem hiding this comment.
I prefer it as-is, for the mentioned reason, to keep things lightweight.
3 participants
Summary
This PR adds 2 new checks to our workflows that run installing
qiskit-serverlessfrommainin Python 3.10 (lowest supported version) and 3.13 (highest supported version). This allows to inspect whether upstream changes affect the library without having to wait for a serverless release or running the tests locally.Details and comments
Given how minimal our current unit tests are, I anticipate that some degree of local testing will still be necessary, but we can use it to incrementally improve the testing suite.