Fix bug with NLV3 and Executor decoders #2506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamFerracin
commented
Dec 11, 2025
|
|
||
| try: | ||
| decoder = AVAILABLE_DECODERS[schema_version] | ||
| decoder, model = AVAILABLE_DECODERS[schema_version] |
Collaborator
Author
There was a problem hiding this comment.
@yaelbh I considered a few different approaches, but eventually converged on what you suggested from the start
yaelbh
reviewed
Dec 21, 2025
| metadata=datum["metadata"], | ||
| rates=datum.rates.to_numpy(), | ||
| rates_std=datum.rates_std.to_numpy(), | ||
| metadata=datum.metadata, |
Collaborator
There was a problem hiding this comment.
Suggested change
| metadata=datum.metadata, | |
| metadata=datum.metadata.model_dump(), |
Collaborator
|
Closing because this PR was merged into #2505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the decoders.
The first fix ensures that the NLV3 creates results of the correct type. Previous to this change, some dictionaries with keys of type
intwere actually returned as dictionaries with keys of typestr.The second fix ensures that the Executor can support more than just "v0_1" models