-
Notifications
You must be signed in to change notification settings - Fork 196
Reintroduce delete_job #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce delete_job #2541
Conversation
SamFerracin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @run_integration_test | ||
| def test_delete_job(self, service): | ||
| """Test deleting a job.""" | ||
| self.skipTest("Deleting jobs not supported on IBM Quantum Platform.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is misleading, and probably why the method was removed in the first place.
The delete job API requires a more elevated role in IAM, one that the CI running this probably doesn't have. I'd re-word this at least (and below).
A better pattern would be trying to run the test and if delete job fails with a 401 or 403 error, then skip the test because whoever is running it doesn't have the correct RBAC privileges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened issue #2548 for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch! Will follow-up in the issue
* Reintroduce delete_job * Add release note
Summary
Reintroduce the
delete_jobendpoint, reverting part of the changes in #2439.Details and comments
Fixes #2523